libc 0.3: Change prototypes for exec* function to match headers #3597
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @JohnTitor (or someone else) some time within the next two weeks. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
|
safinaskar
force-pushed
the
exec
branch
2 times, most recently
from
616bbe0
to
9156030
Compare
Yes, this makes the prototypes harder to use. And less intuitive. But this makes them match headers, and thus now we can properly test them. This fixes rust-lang#1272 Also we fix return types for some Windows exec* functions
But for unknown reasons we still have to skip "fexecve" for Android
|
I rebased multiple times, and now the PR is ready for review |
|
@JohnTitor did you realize that this change is backwards-incompatible, and causes downstream crates' builds to fail? |
|
these commits are in see v0.3 Roadmap. |
|
Ahh, that makes sense. Thanks, @semarie . |
Yes, this makes the prototypes harder to use. And less intuitive.
But this makes them match headers, and thus now we can properly test them. This fixes #1272
This is breaking change