-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update esp-idf time flag #3993
Merged
Merged
Update esp-idf time flag #3993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgross35
approved these changes
Oct 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change makes sense. Do you want this in 0.2 stable, considering it is a breaking change?
Yes, our idea is to get it into 0.2 stable. cc: @ivmarkov |
tgross35
pushed a commit
to tgross35/rust-libc
that referenced
this pull request
Nov 6, 2024
(backport <rust-lang#3993>) (cherry picked from commit 7bd7276)
Merged
acmorrow
added a commit
to acmorrow/micro-rdk
that referenced
this pull request
Nov 26, 2024
Also, note the espidf_time32 flag, added per rust-lang/libc#3993
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the ESP-IDF time flag, instead of having a
espidf_time64
, we will have aespidf_time32
flag.espidf_time64
was enabling support for ESP-IDF 5 (latest stable), whileespidf_time32
enables support for ESP-IDF 4 (which is now end of life). So making ESP-IDF 4 the opt-in and having ESP-IDF 5 enabled by default makes sense.See esp-rs/esp-idf-sys#306 (comment) for more information.
cc: @ivmarkov
Checklist
libc-test/semver
have been updated*LAST
or*MAX
areincluded (see #3131)
cd libc-test && cargo test --target mytarget
);especially relevant for platforms that may not be checked in CI