ci: Check various FreeBSD versions #4159
Draft
+163
−131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @JohnTitor rustbot has assigned @JohnTitor. Use |
|
☔ The latest upstream changes (presumably #4157) made this pull request unmergeable. Please resolve the merge conflicts. |
tgross35
force-pushed
the
freebsd-build-check
branch
from
5c96709
to
bb493a3
Compare
tgross35
added
the
stable-nominated
tgross35
force-pushed
the
freebsd-build-check
branch
from
bb493a3
to
9300c04
Compare
asomers
approved these changes
Nov 27, 2024
| } | ||
|
|
||
| freebsd_versions="\ | ||
| 11 \ | ||
| 12 \ |
There was a problem hiding this comment.
This will test 12 twice, once at line 69-70 and once at 82-83.
There was a problem hiding this comment.
Do you have any idea how best to avoid this? It wouldn't be that bad if there isn't anything straightforward.
Since we suport multiple versions and this is tier 2, we should make sure that we can build with a couple versions. This does not run tests. Additionally, introduce an environment variable for an easy way to override the version for testing. This includes an unrelated cleanup adjustment in `verify-build.sh`
For versions 10, 11, 12, 13, 14, 15, and architectures aarch64, i686,
powerpc64, riscv64gc, and x86_64, I ran the following:
RUST_LIBC_UNSTABLE_FREEBSD_VERSION=15 cargo fix \
-Zbuild-std=core \
--features extra_traits \
--allow-dirty \
--edition \
--broken-code \
--lib \
--target aarch64-unknown-freebsd
tgross35
force-pushed
the
freebsd-build-check
branch
from
1e25591
to
9a942b3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we suport multiple versions and this is tier 2, we should make sure that we can build with a couple versions. This does not run tests.
This introduces an environment variable for an easy way to override the version for testing.