Add IFF_* constants to linux, android and fuchsia
#916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LuoZijun
force-pushed
the
patch-1
branch
2 times, most recently
from
57d09db
to
9927908
Compare
|
Thanks! Unfortunately we can't change the types as that'd be a breaking change, but the additions are certainly possible! |
LuoZijun
force-pushed
the
patch-1
branch
3 times, most recently
from
9ea9d37
to
ae1b5f7
Compare
|
@alexcrichton ok, updated. |
alexcrichton
reviewed
Feb 7, 2018
src/unix/notbsd/mod.rs
Outdated
| @@ -445,6 +445,16 @@ pub const IFF_PORTSEL: ::c_int = 0x2000; | |||
| pub const IFF_AUTOMEDIA: ::c_int = 0x4000; | |||
| pub const IFF_DYNAMIC: ::c_int = 0x8000; | |||
|
|
|||
| cfg_if! { | |||
| if #[cfg(target_os = "android")] { | |||
| pub const IFF_TUN: ::c_int = 0x0001; | |||
There was a problem hiding this comment.
Could these be moved into the android folder to avoid the cfg_if!?
There was a problem hiding this comment.
okay, no problem.
by the way, should keep IFF_TUN/IFF_TAP/IFF_NO_PI type is same as linux ?
There was a problem hiding this comment.
Nah I think it's fine to fix the type for new definitions.
|
@alexcrichton Done. |
|
@bors: r+ |
|
📌 Commit 0f4ae0b has been approved by |
bors
added a commit
that referenced
this pull request
Feb 7, 2018
Add `IFF_*` constants to linux, android and fuchsia Add constants to android and fuchsia: * IFF_TUN * IFF_TAP * IFF_NO_PI Type problem: #915 so change constants type `libc::c_short` to `libc::c_int` : * IFF_*
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add constants to android and fuchsia:
Type problem: #915
so change constants type
libc::c_shorttolibc::c_int: