-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Default RHS to Self for Div and Shl #964
Conversation
This fixes a consistency issue with the other operator traits.
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
Thanks! These are just used during documentation, however, so is this change required for correctness? |
@alexcrichton I assumed it would be required for correct documentation. :) |
Oh we don't actually document these traits as part of the build, they're just required to document other things (it's sort of a hack today) |
I don't take this patch to be urgent. I just took it to be easy while I was fixing the actual code in the rust bug. :) |
@bors: r+ |
📌 Commit 585e115 has been approved by |
Default RHS to Self for Div and Shl This fixes a consistency issue with the other operator traits.
☀️ Test successful - status-appveyor, status-travis |
This fixes a consistency issue with the other operator traits.