Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new sendfile flags for FreeBSD #988

Merged
merged 1 commit into from
May 17, 2018
Merged

Add new sendfile flags for FreeBSD #988

merged 1 commit into from
May 17, 2018

Conversation

morrowa
Copy link
Contributor

@morrowa morrowa commented May 17, 2018

Two new constants for FreeBSD:

  • SF_USER_READAHEAD introduced in FreeBSD 12 in this commit (omitted from tests until FreeBSD 12 is stable)
  • SF_NOCACHE introduced in FreeBSD 11 in this commit

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Contributor

bors commented May 17, 2018

📌 Commit 96ee7bf has been approved by alexcrichton

@bors
Copy link
Contributor

bors commented May 17, 2018

⌛ Testing commit 96ee7bf with merge f464f1b...

bors added a commit that referenced this pull request May 17, 2018
Add new sendfile flags for FreeBSD

Two new constants for FreeBSD:
* `SF_USER_READAHEAD` introduced in FreeBSD 12 [in this commit](freebsd/freebsd-src@b739d60#diff-b3f45d20f63d013e46f59f3f88a84d3d) (omitted from tests until FreeBSD 12 is stable)
* `SF_NOCACHE` introduced in FreeBSD 11 [in this commit](freebsd/freebsd-src@aaa0977#diff-b3f45d20f63d013e46f59f3f88a84d3d)
@bors
Copy link
Contributor

bors commented May 17, 2018

💔 Test failed - status-travis

@morrowa
Copy link
Contributor Author

morrowa commented May 17, 2018

  • 3864.8 failed waiting on an interactive prompt for an Android SDK license agreement (oops!).
  • 3864.16 appears to have panicked without a backtrace. I'll try running the tests locally on my Mac with the same configuration.
  • 3864.34 timed out with no output for 10 minutes. I'm most concerned about this since it's a FreeBSD test and that's what I changed.

@alexcrichton
Copy link
Member

@bors: retry

Hm hopefully spurious!

@bors
Copy link
Contributor

bors commented May 17, 2018

⌛ Testing commit 96ee7bf with merge 5e025d6...

bors added a commit that referenced this pull request May 17, 2018
Add new sendfile flags for FreeBSD

Two new constants for FreeBSD:
* `SF_USER_READAHEAD` introduced in FreeBSD 12 [in this commit](freebsd/freebsd-src@b739d60#diff-b3f45d20f63d013e46f59f3f88a84d3d) (omitted from tests until FreeBSD 12 is stable)
* `SF_NOCACHE` introduced in FreeBSD 11 [in this commit](freebsd/freebsd-src@aaa0977#diff-b3f45d20f63d013e46f59f3f88a84d3d)
@morrowa
Copy link
Contributor Author

morrowa commented May 17, 2018

OK, looks like the only mandatory failure now is the Android build which still needs help to auto-accept the license agreement.

@bors
Copy link
Contributor

bors commented May 17, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing 5e025d6 to master...

@bors bors merged commit 96ee7bf into rust-lang:master May 17, 2018
@morrowa morrowa deleted the new_freebsd_sf_flags branch May 17, 2018 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants