Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moves ifaddrs and some functions to common Linux module #994

Merged
merged 2 commits into from
May 26, 2018

Conversation

bkchr
Copy link
Contributor

@bkchr bkchr commented May 25, 2018

The ifaddrs interface is available since api version 24 in android.
The function signatures are now equal to the standard Linux function
signatures.

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Contributor

bors commented May 25, 2018

📌 Commit 4341010 has been approved by alexcrichton

@bors
Copy link
Contributor

bors commented May 25, 2018

⌛ Testing commit 4341010 with merge a71e3c2...

bors added a commit that referenced this pull request May 25, 2018
Moves `ifaddrs` and some functions to common Linux module

The `ifaddrs` interface is available since api version 24 in android.
The function signatures are now equal to the standard Linux function
signatures.
@bors
Copy link
Contributor

bors commented May 25, 2018

💔 Test failed - status-travis

bkchr added 2 commits May 26, 2018 10:47
The `ifaddrs` interface is available since api version 24 in android.
The function signatures are now equal to the standard Linux function
signatures.
@bkchr
Copy link
Contributor Author

bkchr commented May 26, 2018

@alexcrichton I had forgotten to adapt the tests, now everything works :)

@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Contributor

bors commented May 26, 2018

📌 Commit 6a6dc86 has been approved by alexcrichton

@bors
Copy link
Contributor

bors commented May 26, 2018

⌛ Testing commit 6a6dc86 with merge 4083c89...

bors added a commit that referenced this pull request May 26, 2018
Moves `ifaddrs` and some functions to common Linux module

The `ifaddrs` interface is available since api version 24 in android.
The function signatures are now equal to the standard Linux function
signatures.
@bors
Copy link
Contributor

bors commented May 26, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing 4083c89 to master...

@bors bors merged commit 6a6dc86 into rust-lang:master May 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants