clippy

crates/libm-test/src/domain.rs

@@ -38,10 +38,7 @@ where
 
     /// Helper to get the length of the period in unit `T`.
     fn period() -> Option<T> {
-        if Self::PERIODIC.is_none() {
-            return None;
-        }
-
+        Self::PERIODIC?;
         let start = Self::period_start();
         let end = Self::period_end();
         if start > end { Some(start - end) } else { Some(end - start) }

crates/libm-test/src/f8_impl.rs

@@ -1,3 +1,5 @@
+#![allow(clippy::unusual_byte_groupings)]
+
 use std::cmp::{self, Ordering};
 use std::{fmt, ops};
 
@@ -439,30 +441,19 @@ impl cmp::PartialOrd for f8 {
 
         let a_srep = self.to_bits_signed();
         let b_srep = other.to_bits_signed();
+        let res = a_srep.cmp(&b_srep);
 
-        // If at least one of a and b is positive, we get the same result comparing
-        // a and b as signed integers as we would with a fp_ting-point compare.
-        let res = if a_srep & b_srep >= 0 {
-            if a_srep < b_srep {
-                Ordering::Less
-            } else if a_srep == b_srep {
-                Ordering::Equal
-            } else {
-                Ordering::Greater
-            }
-        // Otherwise, both are negative, so we need to flip the sense of the
-        // comparison to get the correct result.  (This assumes a twos- or ones-
-        // complement integer representation; if integers are represented in a
-        // sign-magnitude representation, then this flip is incorrect).
-        } else if a_srep > b_srep {
-            Ordering::Less
-        } else if a_srep == b_srep {
-            Ordering::Equal
+        if a_srep & b_srep >= 0 {
+            // If at least one of a and b is positive, we get the same result comparing
+            // a and b as signed integers as we would with a fp_ting-point compare.
+            Some(res)
         } else {
-            Ordering::Greater
-        };
-
-        Some(res)
+            // Otherwise, both are negative, so we need to flip the sense of the
+            // comparison to get the correct result.  (This assumes a twos- or ones-
+            // complement integer representation; if integers are represented in a
+            // sign-magnitude representation, then this flip is incorrect).
+            Some(res.reverse())
+        }
     }
 }
 impl fmt::Display for f8 {