[NFC][IR] Type: add getWithNewType() method #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes you want to get a type with same vector element count as the current type, but different element type, but there's no QOL wrapper to do that. Add one.
|
This fixes rust-lang/rust#84654 (comment) which is where #101 doesn't build clang correctly. I tested building LLVM locally but forgot to test building clang! I've tested now and it should build correctly. |
|
Didn't even know we built clang from our llvm-project. Is that for cross-language LTO tests? |
|
Perhaps? I'm unsure |
This was referenced Apr 30, 2021
vext01
pushed a commit
to vext01/llvm-project
that referenced
this pull request
Dec 11, 2023
Don't conflate a call with an unknown target with an indirect call.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes you want to get a type with same vector element count
as the current type, but different element type,
but there's no QOL wrapper to do that. Add one.