Improve error when missing macro argument #322
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
log!
macro matches part of its arguments as$($arg:tt)+
, but the other macros match it as$($arg:tt)*
. That means if a user callserror!()
or any of the other macros with an empty argument, it successfully matches the macro rules of the first macro they called but then turns into an invalid call tolog!
, leading to a confusing error message.This PR uses
$($arg:tt)+
consistently to match arguments.Example:
Before:
After:
Closes #271 (comment).