Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build out initial key values API #324

Merged
merged 8 commits into from
Apr 29, 2019
Merged

Build out initial key values API #324

merged 8 commits into from
Apr 29, 2019

Commits on Apr 9, 2019

  1. build out initial key values API

    @KodrAus
    KodrAus committed Apr 9, 2019
    Configuration menu
    Copy the full SHA
    32d080a View commit details
    Browse the repository at this point in the history

Commits on Apr 18, 2019

  1. address initial PR feedback 

    - fix trailing file newlines
- tweak KeyValuesError type not to rely on deprecated Error APIs
- change ToKey impl from &str to str
- hide the sub-modules under key_values
- add a Visitor impl for Box<impl Visitor>
    @KodrAus
    KodrAus committed Apr 18, 2019
    Configuration menu
    Copy the full SHA
    6faac8a View commit details
    Browse the repository at this point in the history

  2. rename key_values module to kv

    @KodrAus
    KodrAus committed Apr 18, 2019
    Configuration menu
    Copy the full SHA
    53f0eac View commit details
    Browse the repository at this point in the history

  3. refactor Value internals to use trait objects

    @KodrAus
    KodrAus committed Apr 18, 2019
    Configuration menu
    Copy the full SHA
    ee05032 View commit details
    Browse the repository at this point in the history

  4. provide a reasonable Debug impl for KeyValues on a Record

    @KodrAus
    KodrAus committed Apr 18, 2019
    Configuration menu
    Copy the full SHA
    383d80b View commit details
    Browse the repository at this point in the history

Commits on Apr 26, 2019

  1. add from_display to value and some more impls

    @KodrAus
    KodrAus committed Apr 26, 2019
    Configuration menu
    Copy the full SHA
    b5ccd51 View commit details
    Browse the repository at this point in the history

Commits on Apr 27, 2019

  1. rename KeyValueError to kv::Error

    @KodrAus
    KodrAus committed Apr 27, 2019
    Configuration menu
    Copy the full SHA
    d69a8f8 View commit details
    Browse the repository at this point in the history

  2. make deprecated description just a little more semantic

    @KodrAus
    KodrAus committed Apr 27, 2019
    Configuration menu
    Copy the full SHA
    7dea857 View commit details
    Browse the repository at this point in the history