Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Value::to_str to to_cow_str #592

Merged
merged 2 commits into from
Nov 19, 2023
Merged

Conversation

Thomasdezeeuw
Copy link
Collaborator

No description provided.

@Thomasdezeeuw
Copy link
Collaborator Author

Oops, forgot to run with --all-features, please squash the commits.

@darkdragon-001
Copy link

darkdragon-001 commented Mar 2, 2024

FYI: You released a breaking change (this PR) in a patch version update. This broke depending projects like tauri (see linked issues).

I suggest reverting, releasing another patch version update for a fix, apply this change again and release again with updated major version.

@Thomasdezeeuw
Copy link
Collaborator Author

FYI: You released a breaking change (this PR) in a patch version update. This broke depending projects like tauri (see linked issues).

The API that was changed was only enabled by the kv_unstable feature, which as the name implies is unstable. This means that users opted into possible breakages, which is what happened here.

I suggest reverting, releasing another patch version update for a fix, apply this change again and release again with updated major version.

I'm afraid that I don't think that's going to happen as the kv (no _unstable) feature was released in the same version. I suggest updating to it. The kv feature is covered by the same stability guarantees as the rest of the crate (i.e. a rename like this won't happen).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants