Fix: Sticky header disappears by momentum scroll #1070
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the default theme, there is sticky header.
The header will be hidden when the page is scrolled down. like:
This behavior make a problem with momentum scroll.
With momentum scroll,
document.scrollingElement.scrollTop
can be negative number, so scrolling up above the upper limit of a page makes such logs below:The last part of logs is detected as "scrolling down", so
the header disappear.
I Fixed it by coercing the negative value of
document.scrollingElement.scrollTop
into 0.this problem can be reproduce with macOS safari and iOS safari and maybe other momentum scrollable browsers.