Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Slightly increases line height for <p>, <ul> & <ol> #1136

Merged
merged 1 commit into from
Mar 6, 2020
Merged

Slightly increases line height for <p>, <ul> & <ol> #1136

merged 1 commit into from
Mar 6, 2020

Conversation

sergeypedan
Copy link
Contributor

No description provided.

@Dylan-DPC-zz
Copy link

Thanks. Any reasoning behind this?

@sergeypedan
Copy link
Contributor Author

  1. It was not set — left to browser's default CSS — may be inconsistent across browsers.
  2. It was somewhere around 1.4 em which is a little bit too tight. Making it 1.45 em or even up to 1.55 em will improve readability. Actually 1.45 em is quite conservative: Bootstrap's default is 1.5em, cloud.google.com 's as well 1.5 em, A list apart's is 1.66 em.

@Dylan-DPC-zz Dylan-DPC-zz merged commit ca4b85b into rust-lang:master Mar 6, 2020
Ruin0x11 pushed a commit to Ruin0x11/mdBook that referenced this pull request Aug 30, 2020
@Dylan-DPC
Increases line height for p, ul & ol (rust-lang#1136)
e725394
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sergeypedan @Dylan-DPC-zz