Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

summary: turn SoftBreak events into spaces. #1291

Merged
merged 1 commit into from
Jul 31, 2020
Merged

summary: turn SoftBreak events into spaces. #1291

merged 1 commit into from
Jul 31, 2020

Conversation

ericonr
Copy link
Contributor

@ericonr ericonr commented Jul 29, 2020

Summary items that had their name split into two lines ended up with the
last word of one line and the first word of the next line glued
together, since a space wasn't added.

Fixes #1218

@ericonr
Copy link
Contributor Author

ericonr commented Jul 29, 2020

I feel like the change itself is mostly self explanatory, but I can leave a comment and/or create a test case, if desired.

@ericonr
Copy link
Contributor Author

ericonr commented Jul 29, 2020

I'm trying to add a test to it, in the end of the same file. Hope it's enough.

Summary items that had their name split into two lines ended up with the
last word of one line and the first word of the next line glued
together, since a space wasn't added.

Added test case for it.

Fixes #1218
@ericonr
Copy link
Contributor Author

ericonr commented Jul 29, 2020

Test case added c:

Copy link
Contributor

@ehuss ehuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ehuss ehuss merged commit f5ae7c4 into rust-lang:master Jul 31, 2020
Ruin0x11 pushed a commit to Ruin0x11/mdBook that referenced this pull request Aug 30, 2020
summary: turn SoftBreak events into spaces.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sidebar doesn't add a space character when item is split in two lines
2 participants