Prefer bundled version of Source Code Pro #1307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prevents an issue with Firefox 80 on macOS that prevents syntax highlighting from working.
camelid
force-pushed
the
prefer-bundled-scp
branch
from
cda82c2 to
4d9eb9b
Compare
Before (master branch)
After (this branch)
|
camelid
commented
Aug 29, 2020
It's unlikely that the bundled version wouldn't load, and it's especially unlikely that the page would load but the bundled version would not. Also, if it doesn't load, it should fall back to another monospace font, which is fine.
|
Thanks for reviewing! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1304.
This prevents an issue with Firefox 80 on macOS that prevents syntax
highlighting from working.