-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/suggest an edit link #1506
Merged
Merged
Commits on Apr 19, 2021
-
Add "Suggest an edit" link next to "Git repository"
Includes new configuration option `git-repository-edit-baseurl` for supporting non-GitHub repository layouts.
Configuration menu - View commit details
-
Copy full SHA for b3670ec - Browse repository at this point
Copy the full SHA b3670ecView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2b738d4 - Browse repository at this point
Copy the full SHA 2b738d4View commit details -
Configuration menu - View commit details
-
Copy full SHA for dcc642e - Browse repository at this point
Copy the full SHA dcc642eView commit details -
[ReviewFix] Replace edit baseurl with template and make visibility in…
…dependent of git_repository_url.
Configuration menu - View commit details
-
Copy full SHA for bbf54d7 - Browse repository at this point
Copy the full SHA bbf54d7View commit details -
The `IndexPreprocessor` rewrites the path for files named `README.md` to be `index.md`. This breaks the edit link in some circumstances. To address this issues, the `Chapter` struct has now a new attribute called `source_path`. This is initialized with the same value as `path`, but is never ever changed. Finally, the edit link is built by using the `source_path` rather than the `path`.
Configuration menu - View commit details
-
Copy full SHA for 7aff98a - Browse repository at this point
Copy the full SHA 7aff98aView commit details -
Update docs to include example of edit links feature
Add a working example of the edit links feature to the examples
Configuration menu - View commit details
-
Copy full SHA for c3beecc - Browse repository at this point
Copy the full SHA c3beeccView commit details -
Add "edit" links to the pages of mdbook own book
Configuration menu - View commit details
-
Copy full SHA for 94e797f - Browse repository at this point
Copy the full SHA 94e797fView commit details
Commits on Apr 26, 2021
-
Rename git-repository-edit-url-template
Change the name of the git-repository-edit-url-template to be more generic: `edit-url-template` Signed-off-by: Flavio Castelli <fcastelli@suse.com>
Configuration menu - View commit details
-
Copy full SHA for 7525b35 - Browse repository at this point
Copy the full SHA 7525b35View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.