Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/suggest an edit link #1506

Merged
merged 8 commits into from
Apr 26, 2021

Commits on Apr 19, 2021

  1. Add "Suggest an edit" link next to "Git repository"

    Includes new configuration option `git-repository-edit-baseurl` for
    supporting non-GitHub repository layouts.
    xkr47 authored and flavio committed Apr 19, 2021
    Configuration menu
    Copy the full SHA
    b3670ec View commit details
    Browse the repository at this point in the history
  2. [ReviewFix] Fix variable naming

    xkr47 authored and flavio committed Apr 19, 2021
    Configuration menu
    Copy the full SHA
    2b738d4 View commit details
    Browse the repository at this point in the history
  3. [ReviewFix] cargo fmt

    xkr47 authored and flavio committed Apr 19, 2021
    Configuration menu
    Copy the full SHA
    dcc642e View commit details
    Browse the repository at this point in the history
  4. [ReviewFix] Replace edit baseurl with template and make visibility in…

    …dependent of git_repository_url.
    xkr47 authored and flavio committed Apr 19, 2021
    Configuration menu
    Copy the full SHA
    bbf54d7 View commit details
    Browse the repository at this point in the history
  5. Fix generation of edit links

    The `IndexPreprocessor` rewrites the path for files
    named `README.md` to be `index.md`. This breaks the edit link
    in some circumstances.
    
    To address this issues, the `Chapter` struct has now a new attribute
    called `source_path`. This is initialized with the same value as
    `path`, but is never ever changed.
    
    Finally, the edit link is built by using the `source_path` rather
    than the `path`.
    flavio committed Apr 19, 2021
    Configuration menu
    Copy the full SHA
    7aff98a View commit details
    Browse the repository at this point in the history
  6. Update docs to include example of edit links feature

    Add a working example of the edit links feature to the examples
    flavio committed Apr 19, 2021
    Configuration menu
    Copy the full SHA
    c3beecc View commit details
    Browse the repository at this point in the history
  7. mdbook book: show edit link

    Add "edit" links to the pages of mdbook own book
    flavio committed Apr 19, 2021
    Configuration menu
    Copy the full SHA
    94e797f View commit details
    Browse the repository at this point in the history

Commits on Apr 26, 2021

  1. Rename git-repository-edit-url-template

    Change the name of the git-repository-edit-url-template to be more
    generic: `edit-url-template`
    
    Signed-off-by: Flavio Castelli <fcastelli@suse.com>
    flavio committed Apr 26, 2021
    Configuration menu
    Copy the full SHA
    7525b35 View commit details
    Browse the repository at this point in the history