Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update handlebars to 4.0 #1550

Merged
merged 2 commits into from
Jun 6, 2021
Merged

update handlebars to 4.0 #1550

merged 2 commits into from
Jun 6, 2021

Conversation

sunng87
Copy link
Contributor

@sunng87 sunng87 commented May 27, 2021

No description provided.

@ehuss
Copy link
Contributor

ehuss commented May 29, 2021

Thanks! Can you provide some more information about what has changed? Is there anything in the .hbs syntax that is different that might break existing users?

@sunng87
Copy link
Contributor Author

sunng87 commented Jun 2, 2021

@ehuss Sorry for late response. A changelog is available here. There are some minor break changes with subexpressions and template inheritance for template developer. But these should not affect current mdbook use cases.

Copy link
Contributor

@ehuss ehuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, thanks!

@ehuss ehuss merged commit 7ddc3df into rust-lang:master Jun 6, 2021
@tuyen-at-work
Copy link
Contributor

hi @ehuss @sunng87
one nice feature in handlebars 3.x is I can nest things like below:

{{#include {{#include env.txt:1}}.PublishSettings}}

Let says I have env.txt file like this:

dev-env-01

something else

Then above include would become:

{{#include dev-env-01.PublishSettings}}

I used it for my environment list and it really helpful. Few days a go I see this break and look like because we update to Handlebars 4.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants