Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "!important" from code class CSS rule #1551

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

avivace
Copy link

@avivace avivace commented May 27, 2021

to allow style overriding

Fixes #1552

@ehuss
Copy link
Contributor

ehuss commented May 29, 2021

Hm, checking the git history, it looks like this was intentionally added in #1062 to resolve #1061. If both can be resolved, that would be great, but otherwise I don't think it would be good to break the ACE editor.

@YJDoc2
Copy link
Contributor

YJDoc2 commented Sep 30, 2021

Hey, I think setting

.ace_editor {
    line-height: 2;
}

would resolve this issues, while removing the !important tag : see node-red/node-red#2104 and ajaxorg/ace#4000 (comment) .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CSS rules with !important
3 participants