Use the configured book src directory for the edit url template path #1554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshrotenberg
force-pushed
the
edit_url_custom_src
branch
from
0a12d32
to
54b1b17
Compare
use book_config.src for edit path use book_config.src for edit path fmt concat the path, this is a url
joshrotenberg
force-pushed
the
edit_url_custom_src
branch
from
54b1b17
to
60aaa7a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "Suggest an edit" URL used
srcas the top level path to the file to edit regardless of whether the book.tomlsrcconfig was set resulting in an incorrect link to the file. This change uses the actual configuredsrcto build the path instead.Fixes #1543.