Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(playground): show "No output" on playgrounds that print nothing #1599

Merged
merged 1 commit into from
Jul 8, 2021
Merged

feat(playground): show "No output" on playgrounds that print nothing #1599

merged 1 commit into from
Jul 8, 2021

Conversation

notriddle
Copy link
Contributor

Fixes #1594

joshrotenberg
joshrotenberg approved these changes Jul 8, 2021
View reviewed changes
Copy link
Contributor

@joshrotenberg joshrotenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks right to my otherwise JS inexperienced eyes 👀 .

ehuss
ehuss approved these changes Jul 8, 2021
View reviewed changes
Copy link
Contributor

@ehuss ehuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@ehuss ehuss merged commit 8fb6ac7 into rust-lang:master Jul 8, 2021
@notriddle notriddle deleted the notriddle/play-button-no-output branch July 8, 2021 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehuss ehuss ehuss approved these changes

@joshrotenberg joshrotenberg joshrotenberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Play button should print something if there is no output.
3 participants
@notriddle @joshrotenberg @ehuss