-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow specifying preprocessor order #1607
Conversation
I've determined that the order in which preprocessors are run is non-deterministic (blame The question then is: is this acceptable? |
Thanks! I think it would be ideal if the order would be at least stable. Would it be possible to sort the preprocessors by name? |
Sure, I'll see about stabilizing ties. |
Should it be made a contract in the documentation, or should we specify that ties are guaranteed to be identically resolved across runs but not across versions? |
Additionally, do we match, or ignore case? |
I think mentioning that they are otherwise sorted by name would be fine. |
So sticking with the default string sorting should be enough, right? |
Yea, the default string sort should be good. |
Okay, I updated the test to expect |
489bace
to
dc49f17
Compare
dc49f17
to
d8ad68c
Compare
Done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Fixes #1172