Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include chapters with no headers in the search index #1637

Merged
merged 1 commit into from
Sep 3, 2021

Conversation

notriddle
Copy link
Contributor

No description provided.

Copy link
Contributor

@ehuss ehuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! In the future, it would be helpful to have a PR description that discusses the nature of the change (what is changing and why).

@ehuss ehuss merged commit 9634798 into rust-lang:master Sep 3, 2021
@notriddle notriddle deleted the no-headers branch September 3, 2021 17:46
notriddle added a commit to notriddle/placement-by-return that referenced this pull request Oct 4, 2021
This significantly shrinks the pre-compressed search index:

    $ du -h searchindex-old.js searchindex-new.js
    26M	searchindex-old.js
    19M	searchindex-new.js

And shrinks the search index even after it's gzipped:

    $ du -h searchindex-old.js.gz searchindex-new.js.gz
    4.5M	searchindex-old.js.gz
    3.3M	searchindex-new.js.gz

This change requires a newer version of mdBook, with
rust-lang/mdBook#1637
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants