Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pulldown-cmark to 0.8.0 and use Smart Punctuation feature #1668

Merged
merged 4 commits into from
Nov 20, 2021

Conversation

joshrotenberg
Copy link
Contributor

@joshrotenberg joshrotenberg commented Oct 14, 2021

This updates pulldown-cmark to 0.8.0 release notes and use's that version's smart punctuation in place of mdbooks previous curly quotes converter. The configuration item remains the same.

Closes #1663.

@ehuss
Copy link
Contributor

ehuss commented Oct 15, 2021

Thanks! This doesn't seem to enable the smart quotes feature, so I don't think it closes #1663 in spirit. Was that intended?

@joshrotenberg
Copy link
Contributor Author

joshrotenberg commented Nov 19, 2021

Thanks! This doesn't seem to enable the smart quotes feature, so I don't think it closes #1663 in spirit. Was that intended?

Ooops! Fixed! But not yet.

@joshrotenberg
Copy link
Contributor Author

I'm wondering if it makes sense to switch to using the curly_quotes config option to enable this since it looks like we get it for free instead of the current conversion process.

@joshrotenberg joshrotenberg changed the title Update pulldown-cmark to 0.8.0 Update pulldown-cmark to 0.8.0 and use Smart Quotes feature Nov 20, 2021
@joshrotenberg joshrotenberg changed the title Update pulldown-cmark to 0.8.0 and use Smart Quotes feature Update pulldown-cmark to 0.8.0 and use Smart Punctuation feature Nov 20, 2021
Copy link
Contributor

@ehuss ehuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@ehuss ehuss merged commit 2ddcb43 into rust-lang:master Nov 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

delete
2 participants