Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add proper title to 404 page #1693

Merged
merged 2 commits into from
Mar 28, 2022
Merged

Add proper title to 404 page #1693

merged 2 commits into from
Mar 28, 2022

Conversation

rsapkf
Copy link
Contributor

@rsapkf rsapkf commented Nov 20, 2021 •
edited by ehuss
Loading

This adds Page not found title to the 404 page.

Closes #1692

@rsapkf rsapkf marked this pull request as draft November 20, 2021 08:38
@rsapkf rsapkf marked this pull request as ready for review November 20, 2021 08:44
@ehuss
Copy link
Contributor

ehuss commented Nov 20, 2021

I think adding the - {{ book_title }} sounds good, would you mind adding that?

@ehuss ehuss added the S-waiting-on-author Status: The marked PR is awaiting some action (such as code changes) from the PR author. label Dec 20, 2021
@ehuss
Copy link
Contributor

ehuss commented Jan 4, 2022

@rsapkf just checking if you could update this?

ehuss
ehuss approved these changes Mar 28, 2022
View reviewed changes
Copy link
Contributor

@ehuss ehuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went ahead and added the book title here, thanks for the PR!

@ehuss ehuss merged commit 1f04a62 into rust-lang:master Mar 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehuss ehuss ehuss approved these changes

Assignees
No one assigned
Labels
S-waiting-on-author Status: The marked PR is awaiting some action (such as code changes) from the PR author.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Correct page title in 404 page
2 participants
@rsapkf @ehuss