Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Markdown page #1709

Merged
merged 5 commits into from
Dec 19, 2021
Merged

Markdown page #1709

merged 5 commits into from
Dec 19, 2021

Conversation

joshrotenberg
Copy link
Contributor

@joshrotenberg joshrotenberg commented Dec 18, 2021 •
edited
Loading

Adds a new page about markdown to the guide.

Fixes #1708.

@ehuss
Copy link
Contributor

ehuss commented Dec 18, 2021

This looks like a great start! Let me know if you want any feedback yet.

I'm going to work on the documentation a bit this weekend, and this will be great to link to.

@joshrotenberg joshrotenberg marked this pull request as ready for review December 19, 2021 00:01
@joshrotenberg
Copy link
Contributor Author

This looks like a great start! Let me know if you want any feedback yet.

I'm going to work on the documentation a bit this weekend, and this will be great to link to.

Added a few more basic things. I think it's enough of the basics with links elsewhere for more. Let me know if you think I should include any other elements or change things around.

ehuss
ehuss approved these changes Dec 19, 2021
View reviewed changes
Copy link
Contributor

@ehuss ehuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ehuss ehuss merged commit f3e5fce into rust-lang:master Dec 19, 2021
@ehuss
Copy link
Contributor

ehuss commented Dec 20, 2021

@joshrotenberg I posted #1710 with an update to the documentation, which includes some additions to this page. Would you be willing to look over that PR? I realize it is kinda large, but I would appreciate if someone could at least skim it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehuss ehuss ehuss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Document how to include static files and linking to them
2 participants
@joshrotenberg @ehuss