Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Omit words longer than 80 characters from the search index #1833

Merged
merged 2 commits into from
Jun 27, 2022
Merged

Omit words longer than 80 characters from the search index #1833

merged 2 commits into from
Jun 27, 2022

Conversation

mattheww
Copy link
Contributor

This is an updated version of PR #1809, fixed to work with elasticlunr-rs v3.

It fixes #1735 .

@mattheww
When creating the search index, omit words longer than 80 characters
1f8c090 
This avoids creating deeply nested objects in searchindex.json
@mattheww
Test that long words are omitted from the search index.
000a93d 
Note they do appear in the 'docs' part of searchindex.json (so they will be
visible in search teasers).
ehuss
ehuss approved these changes Jun 27, 2022
View reviewed changes
Copy link
Contributor

@ehuss ehuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! It is hard for me to anticipate what issues this might cause as I'm not too familiar with elasticlunr, but I think it should be fine.

@ehuss ehuss merged commit b38792c into rust-lang:master Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehuss ehuss ehuss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SIGSEGV on long line
2 participants
@mattheww @ehuss