-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configurable MathJax Support #1918
base: master
Are you sure you want to change the base?
Conversation
0844ef3
to
123c2b6
Compare
9aff0aa
to
943b4ef
Compare
MathJax 3 was release in 2020 ear. Currently MathJax 4 alpha also available. Anybody, please, review this PR. May be I suggest some useful changes... |
Changing the config structure is a breaking change, so you'll need to find a different short-term solution. Can you say what the differences are between mathjax 2 and 3? Why would someone want to stay with 2? Why use jsdelivr.net instead of the existing cloudflare cdn? Why make the source URL configurable instead of embedding the source? |
You are wrong here. I didn't break anything. I have proposed new functionality that does not conflict with existing configurations.
MathJax version 3 is a complete rewrite from the ground up, with the goal of modernizing MathJax’s internal infrastructure, bringing it more flexibility for use with contemporary web technologies, making it easier to use with NodeJS for pre-processing and server-side support, and making it faster to render your mathematics. Upgrading is everyone's choice. It may or may not be updated. My changes are backward compatible and don't force anyone to update.
This is recommended in the getting started example on the MathJax 3 site.
This allows you to select your preferred source. See your previous question. |
Ah, apologies, I saw that My question about version 2 is about what would happen if mdbook just started to always use version 3? Is the syntax different? What would break? As for the embedded source, I'm asking about whether or not it would be possible to fix #46 by always using a local copy of mathjax instead of using a CDN. That would allow books to be used offline and to simplify the config (so you don't need to specify a source). How difficult would that be? |
I think, all is possible. More from documentation about 2 and 3 version difference:
In the documentation changes, I described how to manually make and use the embedded version of MathJax 3. More infor about Hosting Your Own Copy of MathJax. |
943b4ef
to
cc05e65
Compare
@ehuss, review again, please. |
If `source` starts with `/` interpret it relative to output dir.
76f79d0
to
3efb954
Compare
would this be able to accommodate the use cases in #2069 ? |
Plan:
Just add few lines to your
book.toml
:I'd be grateful if someone could help me update the documentation (perhaps in the next pull request).