Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing clippy lints #2170

Closed
wants to merge 1 commit into from
Closed

Fixing clippy lints #2170

wants to merge 1 commit into from

Conversation

gents83
Copy link

@gents83 gents83 commented Aug 21, 2023

No description provided.

@rustbot rustbot added the S-waiting-on-review Status: waiting on a review label Aug 21, 2023
@@ -75,10 +75,10 @@ fn create_missing(src_dir: &Path, summary: &Summary) -> Result<()> {
/// [`iter()`]: #method.iter
/// [`for_each_mut()`]: #method.for_each_mut
#[derive(Debug, Clone, Default, PartialEq, Serialize, Deserialize)]
#[non_exhaustive]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a breaking change, it was already made in #1854 but it is waiting to be added into a new major release

@ehuss
Copy link
Contributor

ehuss commented Nov 24, 2023

I'm going to close since there are some issues with this, and I would prefer to not go over the readability of various clippy changes.

@ehuss ehuss closed this Nov 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: waiting on a review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants