Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline code with hyperlink is now highlighted #289

Merged
merged 1 commit into from
May 20, 2017

Conversation

budziq
Copy link
Contributor

@budziq budziq commented May 19, 2017

Inline code with hyperlink has now the same color and on hover underline as standard hyperlink.

This is how it looks in rust-cookbook
hilight

Please note that I have zero experience with css / webdev so I am really open to criticism.
solves: https://github.com/azerupi/mdBook/issues/261

@budziq
Copy link
Contributor Author

budziq commented May 19, 2017

Hmm I looks like both travis and appveyor had some infrastructure problems on some builds

@steveklabnik
Copy link
Member

steveklabnik commented May 19, 2017 via email

@azerupi
Copy link
Contributor

azerupi commented May 20, 2017

@budziq thanks for the PR!

For the styling we use a CSS pre-processor called Stylus; so you shouldn't modify the CSS manually because it will get overwritten. Instead you should modify the stylus files and regenerate the CSS.

Check out our brand new contribution guide and let us know if you encountered any difficulties we should document. 😄

@budziq
Copy link
Contributor Author

budziq commented May 20, 2017

Argh! Newbie mistake :( I'll look into stylus later today. Thanks for your tim!

Inline code with hyperlink has now a different color then
standard inline code and has a on hover underline.
@budziq
Copy link
Contributor Author

budziq commented May 20, 2017

I've updated the PR with changes into base.styl and the generated book.css (as seams to be the convention basing on git history).
I have no idea why stylus decided to drop -webkit-border-radius so I might still be doing something wrong.

@azerupi
Copy link
Contributor

azerupi commented May 20, 2017

Thank you! :)
I wouldn't worry too much about the stylus output. It might just be that the webkit property is so old that they decided it wasn't worth inserting it anymore.

@azerupi azerupi merged commit 3f98d69 into rust-lang:master May 20, 2017
@budziq budziq deleted the highlight branch May 20, 2017 15:29
@budziq
Copy link
Contributor Author

budziq commented May 20, 2017

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants