Fix issue 832 #841
Merged
Fix issue 832 #841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check if an existing SUMMARY.md is present to prevent overwriting it with the stub SUMMARY.md. [#832]
|
This looks good, though I think it would be good to have a test in tests/init.rs. |
|
I've added the requested test. |
ehuss
approved these changes
May 8, 2019
Ruin0x11
pushed a commit
to Ruin0x11/mdBook
that referenced
this pull request
Aug 30, 2020
* Add if around stub summary creation Check if an existing SUMMARY.md is present to prevent overwriting it with the stub SUMMARY.md. [rust-lang#832] * Add test for existing SUMMARY.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After a very brief inspection of
src/book/init.rsI came to the conclusion it was not checking for an existingSUMMARY.mdthis PR adds anifand some tracing to check for an existingSUMMARY.mdand only generate the stub files if noSUMMARY.mdis currently present.In my humble opinion this fixes #832.