Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove byteorder dependency #125

Merged
merged 2 commits into from
Aug 20, 2020

Conversation

workingjubilee
Copy link
Member

In the interest of simplifying dependency management for measureme and ultimately rustc, this refactors measureme to remove its dependency on the byteorder crate.

@workingjubilee workingjubilee force-pushed the refactor-byteorder branch 3 times, most recently from e8b7d4e to 9355ffa Compare August 20, 2020 01:00
@workingjubilee
Copy link
Member Author

Next time, try building it for powerpc-unknown-linux-gnu before you push, @workingjubilee.

Copy link
Member

@wesleywiser wesleywiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just one small thing.

measureme/src/stringtable.rs Outdated Show resolved Hide resolved
@wesleywiser wesleywiser self-assigned this Aug 20, 2020
Co-authored-by: Wesley Wiser <wwiser@gmail.com>
@michaelwoerister
Copy link
Member

Nice! Fewer dependencies is always good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants