Remove some unnecessary things #55
Conversation
core_miri_test/Cargo.toml
Outdated
There was a problem hiding this comment.
Does this still run doctests in libcore? I can't quite see how that would work. If the crate doesn't have a lib.rs it won't find any doctests to run, will it?
There was a problem hiding this comment.
Does this still run doctests in libcore?
I was hoping cargo test would run doctests of [[test]]s, but looks like it does not. :(
There was a problem hiding this comment.
Yeah I think only the bin and lib crates get doctested, unfortunately.
| [dev-dependencies] | ||
| rand = { version = "0.8.5", default-features = false, features = ["alloc"] } | ||
| rand_xorshift = "0.3.0" | ||
|
|
||
| [[test]] | ||
| name = "collectionstests" | ||
| name = "alloc" | ||
| path = "../library/alloc/src/lib.rs" |
There was a problem hiding this comment.
Oh, that is clever -- so you are basically turning the unit tests into integration tests, but since they are mostly importing things from alloc (which will then be the sysroot crate) that still works? Or why exactly does this work?
There was a problem hiding this comment.
It didn't. ^^' I merged this with the fake alloc, and now it should work.
|
Looks like this trick won't work for the doctests. (In part due to rust-lang/cargo#5477) Closing. |
@RalfJung This simplifies a few things, which might help in your adventure of putting this all inside the rust-lang/rust tree. If this is not useful, feel free to just close.
miri-test-libstdfeature forcore.miri-test-libstdfeature foralloc.This does not remove the need for
miri-test-libstdfromstd, because if we move thatlib.rsto a[[test]], we will need to find another way to enable#![feature(rustc_private)]in there. (Not sure why the#![feature(rustc_private)]in the fake deps aren't enough. "Fixing" that could also be a solution, I suppose.)