Skip to content

Commit

Permalink
ptr_offset_unsigned_overflow: extend test
Browse files Browse the repository at this point in the history
  • Loading branch information
RalfJung committed Sep 17, 2024
1 parent bdab169 commit c64b664
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 5 deletions.
7 changes: 4 additions & 3 deletions tests/fail/intrinsics/ptr_offset_unsigned_overflow.rs
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
fn main() {
let x = &[0i32; 2];
let x = x.as_ptr().wrapping_add(1);
// If the `!0` is interpreted as `isize`, it is just `-1` and hence harmless.
// However, this is unsigned arithmetic, so really this is `usize::MAX` and hence UB.
unsafe { x.byte_add(!0).read() }; //~ERROR: does not fit in an `isize`
// If `usize::MAX` is interpreted as `isize`, it is just `-1` and hence harmless.
let _ = unsafe { x.byte_offset(usize::MAX as isize) };
// However, `byte_add` uses unsigned arithmetic, so really this is `usize::MAX` and hence UB.
let _ = unsafe { x.byte_add(usize::MAX) }; //~ERROR: does not fit in an `isize`
}
4 changes: 2 additions & 2 deletions tests/fail/intrinsics/ptr_offset_unsigned_overflow.stderr
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
error: Undefined Behavior: overflowing pointer arithmetic: the total offset in bytes does not fit in an `isize`
--> tests/fail/intrinsics/ptr_offset_unsigned_overflow.rs:LL:CC
|
LL | unsafe { x.byte_add(!0).read() };
| ^^^^^^^^^^^^^^ overflowing pointer arithmetic: the total offset in bytes does not fit in an `isize`
LL | let _ = unsafe { x.byte_add(usize::MAX) };
| ^^^^^^^^^^^^^^^^^^^^^^ overflowing pointer arithmetic: the total offset in bytes does not fit in an `isize`
|
= help: this indicates a bug in the program: it performed an invalid operation, and caused Undefined Behavior
= help: see https://doc.rust-lang.org/nightly/reference/behavior-considered-undefined.html for further information
Expand Down

0 comments on commit c64b664

Please sign in to comment.