Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui_test ignores too many tests with "only" condition #2206

Closed
RalfJung opened this issue Jun 6, 2022 · 2 comments · Fixed by #2253
Closed

ui_test ignores too many tests with "only" condition #2206

RalfJung opened this issue Jun 6, 2022 · 2 comments · Fixed by #2253

Comments

@RalfJung
Copy link
Member

RalfJung commented Jun 6, 2022

I just noticed this when running ./miri test on my machine (and it also happens on CI):

tests/pass/linux-getrandom.rs ... ignored (in-test comment)
tests/pass/linux-getrandom-without-isolation.rs ... ignored (in-test comment)

That does not sound right, those tests should run on my Linux system.

@RalfJung
Copy link
Member Author

RalfJung commented Jun 6, 2022

I think this is caused by

if get_pointer_width(target) != s {

here s is "linux", and of course get_pointer_width(target) does not return "linux"...

@RalfJung
Copy link
Member Author

RalfJung commented Jun 6, 2022

#2209 is a hotfix for this.

I think a proper fix would involve syntactically distinguishing "filter on target" from "filter on bitwidth".

@RalfJung RalfJung changed the title ui_test ignores too many tests ui_test ignores too many tests with "only" condition Jun 6, 2022
bors added a commit that referenced this issue Jun 6, 2022
hotfix for incorrect only- logic

This hacks around #2206. We don't currently use `only-32bit` or so, which is why this works.
bors added a commit that referenced this issue Jun 6, 2022
hotfix for incorrect only- logic

This hacks around #2206. We don't currently use `only-32bit` or so, which is why this works.
@bors bors closed this as completed in f664196 Jun 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant