Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up support for "aligning the backing store of allocations" #2836

Closed
RalfJung opened this issue Apr 10, 2023 · 2 comments · Fixed by rust-lang/rust#116724
Closed

Clean up support for "aligning the backing store of allocations" #2836

RalfJung opened this issue Apr 10, 2023 · 2 comments · Fixed by rust-lang/rust#116724

Comments

@RalfJung
Copy link
Member

In rust-lang/rust#108022 I raised some concerns post-landing. Let's track here that these need to be resolved, or else we should remove the interface again. In its current form it is at the very least insufficiently documented; more likely the trait needs to be adjusted.

Cc @CraftSpider

@CraftSpider
Copy link
Contributor

I'm tied whether to respond here or on the original comments - I'll respond there, but copy them over here if you would rather all discussion have one spot.

@RalfJung
Copy link
Member Author

I'm fine with discussing in that PR, this issue is to make sure we don't forget creating a new PR that resolves the problems. :)

github-actions bot pushed a commit that referenced this issue Oct 17, 2023
interpret: clean up AllocBytes

Fixes #2836
Nothing has moved here in half a year, so let's just remove these unused stubs -- they need a proper re-design anyway.

r? `@oli-obk`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants