Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alloc access tracking shows spurious reads after each write #3347

Closed
RalfJung opened this issue Mar 3, 2024 · 0 comments · Fixed by rust-lang/rust#122249
Closed

Alloc access tracking shows spurious reads after each write #3347

RalfJung opened this issue Mar 3, 2024 · 0 comments · Fixed by rust-lang/rust#122249

Comments

@RalfJung
Copy link
Member

RalfJung commented Mar 3, 2024

After each write we do validation which causes reads, and these reads actually trigger the before_memory_read machine hook and then cause alloc access tracking to print.

It seems to me like we probably want to not call the hook for such "fake" reads at all? These reads don't actually exist in the AM; usually the value would get validated "while copying" but Miri doesn't support that so we do some extra reads.

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Mar 11, 2024
interpret: do not call machine read hooks during validation

Fixes rust-lang/miri#3347

r? `@oli-obk`
rust-timer added a commit to rust-lang-ci/rust that referenced this issue Mar 11, 2024
Rollup merge of rust-lang#122249 - RalfJung:machine-read-hook, r=oli-obk

interpret: do not call machine read hooks during validation

Fixes rust-lang/miri#3347

r? ``@oli-obk``
github-actions bot pushed a commit that referenced this issue Mar 12, 2024
interpret: do not call machine read hooks during validation

Fixes #3347

r? ``@oli-obk``
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant