You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
After each write we do validation which causes reads, and these reads actually trigger the before_memory_read machine hook and then cause alloc access tracking to print.
It seems to me like we probably want to not call the hook for such "fake" reads at all? These reads don't actually exist in the AM; usually the value would get validated "while copying" but Miri doesn't support that so we do some extra reads.
The text was updated successfully, but these errors were encountered:
Rollup merge of rust-lang#122249 - RalfJung:machine-read-hook, r=oli-obk
interpret: do not call machine read hooks during validation
Fixesrust-lang/miri#3347
r? ``@oli-obk``
After each write we do validation which causes reads, and these reads actually trigger the
before_memory_read
machine hook and then cause alloc access tracking to print.It seems to me like we probably want to not call the hook for such "fake" reads at all? These reads don't actually exist in the AM; usually the value would get validated "while copying" but Miri doesn't support that so we do some extra reads.
The text was updated successfully, but these errors were encountered: