FreeBSD: implement support for pthread synchronization primitives #3571
Labels
A-concurrency
Area: affects our concurrency (multi-thread) support
A-freebsd
Area: affects our FreeBSD target support
A-shims
Area: This affects the external function shims
C-enhancement
Category: a PR with an enhancement or an issue tracking an accepted enhancement
Comments
RalfJung
added
C-enhancement
RalfJung
changed the title
RalfJung
changed the title
|
Blocked on #3749. |
RalfJung
removed
the
E-good-second-issue
RalfJung
pushed a commit
to RalfJung/rust
that referenced
this issue
Sep 17, 2024
support pthread primitives on FreeBSD Fixes rust-lang/miri#3571: makes out pthread implementation support FreeBSD. FreeBSD sets PHTREAD_MUTEX_DEFAULT == PHTREAD_MUTEX_ERRORCK, so the logic for handling "default vs explicitly set mutex kind" had to be adjusted. The rest is just some general cleanup of the pthread logic, and I realized that we can enable the std::sync tests on Solarish.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We currently don't support the pthread synchronization primitives on FreeBSD. And it turns out that supporting them will require some refactoring of how we implement those primitives: on FreeBSD,
pthread_mutex_tet al are just a pointer to the actual data. That means on a 32bit system they are only 4 bytes large, which is not large enough for us to store the data we need to store directly in thepthread_mutex_t.So we should move that data out of machine memory into dedicated machine state, which also has the advantage of making it more tamper-resistant. Once that's done, implementing FreeBSD support should be fairly easy.
The text was updated successfully, but these errors were encountered: