Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add option to track call IDs #1463

Merged
merged 1 commit into from
Jul 2, 2020
Merged

Conversation

RalfJung
Copy link
Member

@RalfJung RalfJung commented Jul 2, 2020

No description provided.

@oli-obk
Copy link
Contributor

oli-obk commented Jul 2, 2020

would be nice if we had a reasonable scheme for testing these things at some point. Maybe we could use the stderr regex replacement schemes to hide the actual ids?

@RalfJung
Copy link
Member Author

RalfJung commented Jul 2, 2020

Sure, would be nice -- but also I don't think we have ever had trouble with a bug in these tracking flags.

@RalfJung
Copy link
Member Author

RalfJung commented Jul 2, 2020

I removed the rustup as it actually requires a test change; will do that separately.

Fine to land as-is?

@oli-obk
Copy link
Contributor

oli-obk commented Jul 2, 2020

@bors r+

@bors
Copy link
Contributor

bors commented Jul 2, 2020

📌 Commit c379793 has been approved by oli-obk

@bors
Copy link
Contributor

bors commented Jul 2, 2020

⌛ Testing commit c379793 with merge e7ef64f...

@oli-obk
Copy link
Contributor

oli-obk commented Jul 2, 2020

Looks fine to me. Do you know if it's possible to detect a protector-caused stacked borrows violation and thus add a suggestion to the diagnostic telling you to add the new flag to your invocation to learn more?

@bors
Copy link
Contributor

bors commented Jul 2, 2020

☀️ Test successful - checks-travis, status-appveyor
Approved by: oli-obk
Pushing e7ef64f to master...

@bors bors merged commit e7ef64f into rust-lang:master Jul 2, 2020
@RalfJung
Copy link
Member Author

RalfJung commented Jul 2, 2020

Yes, that is possible. It's this code path:

if global.is_active(call) {

@RalfJung RalfJung deleted the track-call-id branch July 2, 2020 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants