Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

accept some post-monomorphization errors #1503

Merged
merged 1 commit into from
Aug 10, 2020
Merged

Conversation

RalfJung
Copy link
Member

@RalfJung RalfJung commented Aug 9, 2020

For #1382, we also need to allow ReferencedConstant post-monomorphization errors. The other post-monomorphization errors should still be impossible to trigger in Miri. The fix is not complete though without rust-lang/rust#75339.

@RalfJung RalfJung changed the title test post-monomorphization const errors accept some post-monomorphization errors Aug 10, 2020
@RalfJung
Copy link
Member Author

We can land this part now without waiting for rust-lang/rust#75339.
@bors r+

@bors
Copy link
Contributor

bors commented Aug 10, 2020

📌 Commit 5ea5e9f has been approved by RalfJung

@bors
Copy link
Contributor

bors commented Aug 10, 2020

⌛ Testing commit 5ea5e9f with merge 4d0651f...

bors added a commit that referenced this pull request Aug 10, 2020
accept some post-monomorphization errors

Miri test for rust-lang/rust#75339. We also need to allow `ReferencedConstant` post-monomorphization errors. The other post-monomorphization errors should still be impossible to trigger in Miri.

Fixes #1382.
@RalfJung
Copy link
Member Author

@bors retry

@bors
Copy link
Contributor

bors commented Aug 10, 2020

⌛ Testing commit 5ea5e9f with merge 1edd231...

@bors
Copy link
Contributor

bors commented Aug 10, 2020

☀️ Test successful - checks-travis, status-appveyor
Approved by: RalfJung
Pushing 1edd231 to master...

@bors bors merged commit 1edd231 into rust-lang:master Aug 10, 2020
@RalfJung RalfJung deleted the post-mono branch August 10, 2020 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-blocked-on-rust Status: Blocked on landing a Rust PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants