implement simd_eq and simd_reduce_any #1978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think that's correct, actually. It wants to be allowed to use a vectorwise signed integer minimum when lowering to the machine code. |
|
Oh, I see. I hope portable-simd makes sure that no other bit patterns ever reach those intrinsics, then. ;) |
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Feb 21, 2022
CTFE engine: Scalar: expose size-generic to_(u)int methods This matches the size-generic constructors `Scalar::from_(u)int`, and it would have helped in rust-lang/miri#1978. r? `@oli-obk`
|
@bors r+ |
|
📌 Commit 1ac1e55 has been approved by |
|
☀️ Test successful - checks-actions |
|
We do, effectively, because we only combine that intrinsic with the Mask types, but fortunately we also now have a way to find out if we don't. ^^; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This lets us re-enable the division and modulo tests, since those operations now internally use simd_eq and simd_reduce_any.
However, I am not sure what exactly the rules are for simd_reduce_any. @workingjubilee for now I made it UB to call those with inputs that are not all-0 or all-1, but that might be taking it too far?