Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

miri-script: Transform Windows paths to Unix. #2877

Closed
wants to merge 4 commits into from
Closed

miri-script: Transform Windows paths to Unix. #2877

wants to merge 4 commits into from

Commits on May 5, 2023

  1. miri-script: Transform Windows paths to unix. 

    python3 snippet used to fill $MIRIDIR variable returns native paths.
Down the line in `bench` subcommand this leads to benchmark setup
failure, preventing contributors from running benchmarks on Windows
hosts.

This commit replaces usage of native os.path module with pathlib, which
explicitly converts paths to Unix flavour.
    @osiewicz
    osiewicz committed May 5, 2023
    Configuration menu
    Copy the full SHA
    0255998 View commit details
    Browse the repository at this point in the history

  2. Check ./miri bench in CI

    @osiewicz
    osiewicz committed May 5, 2023
    Configuration menu
    Copy the full SHA
    ca60799 View commit details
    Browse the repository at this point in the history

  3. miri-script: Clear CARGO_EXTRA_FLAGS

    @osiewicz
    osiewicz committed May 5, 2023
    Configuration menu
    Copy the full SHA
    24c8829 View commit details
    Browse the repository at this point in the history

Commits on May 6, 2023

  1. Constrain miri bench test to host platforms. 

    Document the reason for CARGO_EXTRA_FLAGS being cleared.
    @osiewicz
    osiewicz committed May 6, 2023
    Configuration menu
    Copy the full SHA
    b157354 View commit details
    Browse the repository at this point in the history