Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle closures in get_field_ty #306

Merged
merged 1 commit into from
Aug 24, 2017
Merged

Handle closures in get_field_ty #306

merged 1 commit into from
Aug 24, 2017

Conversation

RalfJung
Copy link
Member

Fixes #304

@RalfJung RalfJung mentioned this pull request Aug 19, 2017
Closed
oli-obk
oli-obk approved these changes Aug 19, 2017
View reviewed changes
Copy link
Contributor

@oli-obk oli-obk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, merge once rustc contains your changes which fix xargo

@RalfJung
Copy link
Member Author

Strange. Travis says the test passed, but GitHub says it is still running. :/

@eddyb
Copy link
Member

eddyb commented Aug 24, 2017

@RalfJung I've seen it elsewhere too. Pretty sure it has to do with the GitHub downtime on Monday.
You should rebase (since you have an extra merge commit anyway) and force push.

@oli-obk oli-obk merged commit f860ad8 into rust-lang:master Aug 24, 2017
@RalfJung RalfJung deleted the closures branch August 29, 2017 14:13
@joshlf joshlf mentioned this pull request Dec 5, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oli-obk oli-obk oli-obk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RalfJung @eddyb @oli-obk