Add epoll EPOLLHUP flag support #3814
Conversation
|
@rustbot ready |
| @@ -69,17 +69,21 @@ pub struct EpollReadyEvents { | |||
| /// Stream socket peer closed connection, or shut down writing | |||
| /// half of connection. | |||
| pub epollrdhup: bool, | |||
| /// For stream socket, this event merely indicates that the peer | |||
| /// closed its end of the channel. | |||
| pub epollhup: bool, | |||
There was a problem hiding this comment.
So, there's some subtle difference between RDHUP and HUP. But I don't really understand it... and it seems we are ignoring that difference and setting the two flags together. Could that become a problem?
There was a problem hiding this comment.
From my understanding, EPOLLRDHUP is more specific than EPOLLHUP. It will be returned even when the peer only closing its writing half. Closing wriitng half will require shutdown.
For example,
If we use shutdown(sv[1], SHUT_WR); only EPOLLRDHUP will be triggered. If we use shutdown(sv[1], SHUT_RDWR); or close(sv[1]), both EPOLLHUP and EPOLLRDHUP will be triggered.
Since we don't have shutdown for now, I think they will have the same behaviour.
|
@bors r+ |
|
☀️ Test successful - checks-actions |
Related discussion in #3811 (comment).
This PR added support for
EPOLLHUPflag.