Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

a bit of refactoring in "sync" #3874

Merged
merged 2 commits into from
Sep 9, 2024
Merged

a bit of refactoring in "sync" #3874

merged 2 commits into from
Sep 9, 2024

Conversation

RalfJung
Copy link
Member

@RalfJung RalfJung commented Sep 9, 2024

  • Use Box<dyn Any> to keep the "extra data" local to the module implementing the primitive
  • Pass around places, not pointers

Cc @Mandragorian -- sorry I couldn't resist and did the Any thing ;)

@RalfJung
Copy link
Member Author

RalfJung commented Sep 9, 2024

@bors r+

@bors
Copy link
Collaborator

bors commented Sep 9, 2024

📌 Commit 59f6871 has been approved by RalfJung

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Sep 9, 2024

⌛ Testing commit 59f6871 with merge 53eaa8b...

@bors
Copy link
Collaborator

bors commented Sep 9, 2024

☀️ Test successful - checks-actions
Approved by: RalfJung
Pushing 53eaa8b to master...

@bors bors merged commit 53eaa8b into rust-lang:master Sep 9, 2024
8 checks passed
@RalfJung RalfJung deleted the sync branch September 9, 2024 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants