Do not store synchronization primitive IDs in adressable memory #3966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bors r+ |
bors
added a commit
that referenced
this pull request
Oct 12, 2024
Do not store synchronization primitive IDs in adressable memory We shouldn't store this in a place where the program can mess with it. Fixes #1649
|
@bors r+ retry |
bors
added a commit
that referenced
this pull request
Oct 12, 2024
Do not store synchronization primitive IDs in adressable memory We shouldn't store this in a place where the program can mess with it. Fixes #1649
RalfJung
added
the
S-blocked
|
@bors r- Blocked by rust-lang/rust#131593 |
|
💔 Test failed - checks-actions |
RalfJung
force-pushed
the
dont-trust-the-user
branch
from
67d47fc
to
d5e126e
Compare
RalfJung
commented
Oct 13, 2024
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Oct 13, 2024
miri: avoid cloning AllocExtra We shouldn't be cloning Miri allocations, so make `AllocExtra::clone` panic instead, and adjust the one case where we *do* clone (the leak check) to avoid cloning. This is in preparation for rust-lang/miri#3966 where I am adding something to `AllocExtra` that cannot (easily) be cloned. r? `@saethlin`
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Oct 14, 2024
miri: avoid cloning AllocExtra We shouldn't be cloning Miri allocations, so make `AllocExtra::clone` panic instead, and adjust the one case where we *do* clone (the leak check) to avoid cloning. This is in preparation for rust-lang/miri#3966 where I am adding something to `AllocExtra` that cannot (easily) be cloned. r? ``@saethlin``
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 14, 2024
Rollup merge of rust-lang#131593 - RalfJung:alloc-no-clone, r=saethlin miri: avoid cloning AllocExtra We shouldn't be cloning Miri allocations, so make `AllocExtra::clone` panic instead, and adjust the one case where we *do* clone (the leak check) to avoid cloning. This is in preparation for rust-lang/miri#3966 where I am adding something to `AllocExtra` that cannot (easily) be cloned. r? ``@saethlin``
RalfJung
pushed a commit
to RalfJung/miri
that referenced
this pull request
Oct 14, 2024
miri: avoid cloning AllocExtra We shouldn't be cloning Miri allocations, so make `AllocExtra::clone` panic instead, and adjust the one case where we *do* clone (the leak check) to avoid cloning. This is in preparation for rust-lang#3966 where I am adding something to `AllocExtra` that cannot (easily) be cloned. r? ``@saethlin``
RalfJung
force-pushed
the
dont-trust-the-user
branch
from
d5e126e
to
1853600
Compare
RalfJung
force-pushed
the
dont-trust-the-user
branch
from
1853600
to
323ab1c
Compare
|
@bors r+ |
|
☀️ Test successful - checks-actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We shouldn't store this in a place where the program can mess with it.
Fixes #1649
Blocked by rust-lang/rust#131593