Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch CI to merge queues #3981

Merged
merged 1 commit into from
Oct 22, 2024
Merged

Conversation

Kobzol
Copy link
Contributor

@Kobzol Kobzol commented Oct 21, 2024

This should be merged in cooperation with an infra admin.

Copy link
Member

@MarcoIeni MarcoIeni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

.github/workflows/ci.yml Show resolved Hide resolved
.github/workflows/ci.yml Show resolved Hide resolved
Copy link
Member

@RalfJung RalfJung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, I have one more comment nit that helps explain why we need the if: at all.

With that nit applied, feel free to land this and do the infra-side changes whenever it is convenient for you.

.github/workflows/ci.yml Outdated Show resolved Hide resolved
@Kobzol
Copy link
Contributor Author

Kobzol commented Oct 22, 2024

Added the all caps part and your suggestion for the comment. Thanks for the review!

Copy link
Member

@MarcoIeni MarcoIeni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great description. We could copy it to other rust repos as well 👍

@MarcoIeni MarcoIeni added this pull request to the merge queue Oct 22, 2024
Merged via the queue into rust-lang:master with commit 0bf9284 Oct 22, 2024
6 checks passed
@Kobzol Kobzol deleted the ci-merge-queue branch October 22, 2024 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants