Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pthread-sync test: avoid confusing error when running with preemption #4020

Merged
merged 1 commit into from
Nov 9, 2024

Conversation

RalfJung
Copy link
Member

@RalfJung RalfJung commented Nov 9, 2024

Currently, panics can lead to data races, which is confusing.

@RalfJung RalfJung mentioned this pull request Nov 9, 2024
@RalfJung
Copy link
Member Author

RalfJung commented Nov 9, 2024

Ah damn, this needs thread parking which needs futexes...

@tiif
Copy link
Contributor

tiif commented Nov 9, 2024

Thanks for fixing the confusing error! :)

@RalfJung RalfJung added this pull request to the merge queue Nov 9, 2024
@RalfJung RalfJung changed the title pthread-sync test: use thread::scope for more reliable thread scoping pthread-sync test: avoid confusing error when running with preemption Nov 9, 2024
Merged via the queue into rust-lang:master with commit b7839b6 Nov 9, 2024
7 checks passed
@RalfJung RalfJung deleted the thread-sope branch November 9, 2024 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants