Rustup for retagging #506
Merged
Rustup for retagging #506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n with optimizations and we can finally stop mutating the state on deref
Not all of them pass validation...
|
The retagging PR is in nightly now. |
|
Yay Travis is green :) |
oli-obk
reviewed
Nov 3, 2018
| size: Size, | ||
| ) -> EvalResult<'tcx> { | ||
| // This is like mutating | ||
| self.use_and_maybe_re_borrow(ptr, size, UsageKind::Write, None) |
There was a problem hiding this comment.
there's nothing else happening? is the fact that the allocation is gone enough?
There was a problem hiding this comment.
I think so. What else should happen?
There's a FIXME for doing something with barriers later.
There was a problem hiding this comment.
yea... I was thinking like "clearing the borrow stack", but that's kind of of useless on a deallocated allocation... I can't think of anything here. I was mostly surprised how easy this case seems
oli-obk
approved these changes
Nov 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Matches rust-lang/rust#55316
Also make our use of
-Zflags more consistent.