Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong lifetime of TyCtxt #773

Closed
wants to merge 1 commit into from

Conversation

tesuji
Copy link
Contributor

@tesuji tesuji commented Jun 14, 2019

@RalfJung
Copy link
Member

Please also update the rust-version file to tell CI to use the new version.

@tesuji
Copy link
Contributor Author

tesuji commented Jun 14, 2019

Done.

@RalfJung
Copy link
Member

RalfJung commented Jun 14, 2019

Awesome, thanks a lot. :)

I was just starting to do this update myself, but you were faster. :D

@RalfJung
Copy link
Member

Oh dang. We can't land this because CI fails until rust-lang/rust#61828 has landed.

Argh, those dependency chains. :/

@RalfJung
Copy link
Member

Most likely that PR will not make it into the next nightly so we can only land this one here on Sunday, meaning the "latest available Miri" will be broken until at least Monday. :(

@RalfJung
Copy link
Member

Ah, I can make a Rust PR with an unmerged branch. So I updated rust-lang/rust#61828 to includes this. Please don't force-push or we will all be confused!

@tesuji
Copy link
Contributor Author

tesuji commented Jun 14, 2019

Ok sure!

@RalfJung RalfJung mentioned this pull request Jun 16, 2019
@RalfJung
Copy link
Member

I made this PR part of #775, to make sure we don't get a stale submodule in the rustc repo.

Thanks again for this!

@RalfJung RalfJung closed this Jun 16, 2019
@tesuji tesuji deleted the lifetime-TyCtxt branch June 16, 2019 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants